Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually check alignment in BlobVec test aligned_zst #10885

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Actually check alignment in BlobVec test aligned_zst #10885

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf0c8a6
Actually check alignment BlobVec test aligned_zst
stepancheg Dec 5, 2023
d43b896
Add a documenting comment to the test.
james7132 Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crates/bevy_ecs/src/storage/blob_vec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ mod tests {
use crate::{component::Component, ptr::OwningPtr, world::World};

use super::BlobVec;
use std::{alloc::Layout, cell::RefCell, rc::Rc};
use std::{alloc::Layout, cell::RefCell, mem, rc::Rc};

// SAFETY: The pointer points to a valid value of type `T` and it is safe to drop this value.
unsafe fn drop_ptr<T>(x: OwningPtr<'_>) {
Expand Down Expand Up @@ -626,7 +626,9 @@ mod tests {
let mut count = 0;

let mut q = world.query::<&Zst>();
for &Zst in q.iter(&world) {
for zst in q.iter(&world) {
// Ensure that the references returned are properly aligned.
assert_eq!(zst as *const Zst as usize % mem::align_of::<Zst>(), 0);
james7132 marked this conversation as resolved.
Show resolved Hide resolved
count += 1;
}

Expand Down