Revert rendering-related associated type name changes

[alice-i-cecile]

Objective

Can anyone explain to me the reasoning of renaming all the types named Query to Data. I'm talking about this PR #10779 It doesn't make sense to me that a bunch of types that are used to run queries aren't named Query anymore. Like ViewQuery on the ViewNode is the type of the Query. I don't really understand the point of the rename, it just seems like it hides the fact that a query will run based on those types.

@IceSentry

Solution

Revert several renames in #10779.

Changelog

• ViewNode::ViewData is now ViewNode::ViewQuery again.

Migration Guide

• This PR amends the migration guide in Rename WorldQueryData & WorldQueryFilter to QueryData & QueryFilter #10779

[alice-i-cecile]

Of the remaining changes, I could go either way on the renames. @IceSentry, I'll defer to your preferences here: just tell me which ones you'd like reverted.

[JMS55]

I prefer ViewNode::ViewQuery

[IceSentry]

Here's my opinion on all of these:

• Trait's ExtractComponent type Query has been renamed to Data.
  • Revert it to Query or QueryData
• Trait's GetBatchData types Query & QueryFilter has been renamed to Data & Filter, respectively.
  • QueryData and QueryFilter
• Trait's ExtractInstance type Query has been renamed to Data.
  • Revert it to Query or QueryData
• Trait's ViewNode type ViewQuery has been renamed to ViewData.
• Trait's RenderCommand types ViewWorldQuery & ItemWorldQuery has been renamed to ViewData & ItemData, respectively.
  • I'd prefer ViewQuery and ItemQuery

Essentially, in the spirit of the original PR, drop the World where it isn't needed, but keep the Query terminology otherwise. I mostly don't like when types are just called Data because it doesn't really give any hints as to what it actually is. I guess it makes sense to use QueryData where applicable to keep consistency with the rest of the engine. I just don't want to lose the Query part.

[JoJoJet]

I agree with this. I think we should also implement the other renames IceSentry suggested.

[atlv24]

looks good, also here's icesentry's rename suggestions implemented and tested
alice-i-cecile#163