Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missed negation during accessibility refactor #11206

Merged
merged 1 commit into from
Jan 3, 2024
Merged

missed negation during accessibility refactor #11206

merged 1 commit into from
Jan 3, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jan 3, 2024

Objective

thread 'main' panicked at .cargo/registry/src/index.crates.io-6f17d22bba15001f/accesskit_consumer-0.16.1/src/tree.rs:139:9:
assertion `left == right` failed
  left: 1
 right: 0
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Encountered a panic in system `bevy_winit::accessibility::update_accessibility_nodes`!
Encountered a panic in system `bevy_app::main_schedule::Main::run_main`!

Solution

  • Re-add lost negation

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-Accessibility A problem that prevents users with disabilities from using Bevy labels Jan 3, 2024
@mockersf mockersf mentioned this pull request Jan 3, 2024
Merged
rparrett
rparrett approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@rparrett rparrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity, I can only reproduce with a screen reader active. But I can confirm the problem and fix, and the fix makes sense to me.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 3, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 3, 2024
Merged via the queue into bevyengine:main with commit 5511483 Jan 3, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rparrett rparrett rparrett approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Accessibility A problem that prevents users with disabilities from using Bevy C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @rparrett @alice-i-cecile