Use Direction3d for gizmos.circle normal #11422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix weird visuals when drawing a gizmo with a non-normed normal.
Fixes #11401
Solution
Just normalize right before we draw. Could do it when constructing the builder but that seems less consistent.
Changelog
Migration Guide
Direction3d::new(vec).unwrap_or(default)
or potentiallyDirection3d::new_unchecked(vec)
if you know your vec is definitely normalized.