Fix wrong transmuted type in TaskPool::scope_with_executor_inner
#11455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkiFire13
force-pushed
the
fix-wrong-transmute
branch
2 times, most recently
from
dcf5c96
to
e174ddd
Compare
SkiFire13
force-pushed
the
fix-wrong-transmute
branch
from
e174ddd
to
eec5725
Compare
doonv
approved these changes
Jan 21, 2024
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Jan 21, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
#8219 changed the target type of a
transmutewithout changing the one transmuting from (see the relevant diff), making them incompatible. This PR fixes this by changing the initial type to match the target one (modulo lifetimes).Solution
Change the type to be transmuted from to match the one transmuting into (modulo lifetimes)