Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Copy for ElementState #1154

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Implement Copy for ElementState #1154

merged 1 commit into from
Dec 28, 2020

Conversation

bgourlie
Copy link
Contributor

It seems like ElementState should be a copy type. This addresses a minor annoyance I've encountered where I have to manually clone it to avoid move errors.

@Moxinilian Moxinilian added C-Code-Quality A section of code that is hard to understand or change A-Input Player input via keyboard, mouse, gamepad, and more labels Dec 28, 2020
@cart
Copy link
Member

cart commented Dec 28, 2020

I dig it. Thanks!

@cart cart merged commit b94f266 into bevyengine:master Dec 28, 2020
@bgourlie bgourlie deleted the element-state-copy branch December 29, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgourlie @cart @Moxinilian