bevy_dynamic_plugin: fix unsafe_op_in_unsafe_fn
lint
#11622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
unsafe_op_in_unsafe_fn
lint #11590.Solution
unsafe_op_in_unsafe_fn
forbevy_dynamic_plugin
.Changelog
bevy_dynamic_plugin::dynamically_load_plugin
.I had a few issues, specifically with the safety comment on
dynamically_load_plugin
. There are three different unsafe functions called within the function body, and they all need their own justification / message.Also, would it be unsound to call
dynamically_load_plugin
multiple times on the same file? I feel the documentation needs to be more clear.