Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example for bounding volumes and intersection tests #11666

Merged
merged 4 commits into from
Feb 3, 2024
Merged

Add example for bounding volumes and intersection tests #11666

merged 4 commits into from
Feb 3, 2024

Conversation

NiseVoid
Copy link
Contributor

@NiseVoid NiseVoid commented Feb 2, 2024

Objective

  • Create an example for bounding volumes and intersection tests

Solution

  • Add an example with a few bounding volumes, created from primitives
  • Allow the user to cycle trough the different intersection tests

@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples A-Math Fundamental domain-agnostic mathematical operations labels Feb 2, 2024
@NiseVoid
Copy link
Contributor Author

NiseVoid commented Feb 2, 2024

out.mp4

This is what the example looks like.

@alice-i-cecile
Copy link
Member

That example video is a fantastic candidate for the blog post.

alice-i-cecile
alice-i-cecile approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in its current form. Would you like me to merge #11072 now so you can use the gizmos?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

The generated examples/README.md is out of sync with the example metadata in Cargo.toml or the example readme template. Please run cargo run -p build-templated-pages -- update examples to update it, and commit the file change.

@alice-i-cecile alice-i-cecile added this to the 0.13 milestone Feb 2, 2024
@NiseVoid
Copy link
Contributor Author

NiseVoid commented Feb 2, 2024

I filled up the duplicate circle spots with other shapes now:

image

Jondolf
Jondolf approved these changes Feb 3, 2024
View reviewed changes
Copy link
Contributor

@Jondolf Jondolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jondolf Jondolf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 3, 2024
@alice-i-cecile
Copy link
Member

Ran this locally: looks awesome. Great stuff!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 3, 2024
Merged via the queue into bevyengine:main with commit ab9447a Feb 3, 2024
27 of 28 checks passed
tjamaan pushed a commit to tjamaan/bevy that referenced this pull request Feb 6, 2024
@NiseVoid @tjamaan
Add example for bounding volumes and intersection tests (bevyengine#1…
0aa0093 
…1666)

# Objective

- Create an example for bounding volumes and intersection tests

## Solution

- Add an example with a few bounding volumes, created from primitives
- Allow the user to cycle trough the different intersection tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@Jondolf Jondolf Jondolf approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.
3 participants
@NiseVoid @alice-i-cecile @Jondolf