Text2d render quality #1171
Merged
Text2d render quality #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
reviewed
Jan 1, 2021
Moxinilian
added
C-Feature
fixes glyph shimmering of animated text
blunted2night
force-pushed
the
text2d-render-quality
branch
from
d77f1d8
to
d68bdb8
Compare
…ring The result of layout of sequence of glyphs causes individuals to have fractional positions, but since glyph renderings are reused for future instances of that glyph, this produces errors. This change accepts the errors but repositions the glyph to "0, 0" in an effort to get the cleanest possible rendering.
blunted2night
force-pushed
the
text2d-render-quality
branch
from
d68bdb8
to
c5ad039
Compare
|
The "reposition glyph rendering" commit was just something I was playing with but it does seem to improve placement in the different tests. |
|
Awesome. Looks like this works as expected on 1x and 2x (which are the scales i can test at). |
blunted2night
added a commit
to blunted2night/bevy
that referenced
this pull request
Jan 3, 2021
cart
pushed a commit
that referenced
this pull request
Jan 3, 2021
* cleanup unnecessary changes from PR #1171 * add feature to correctly render glyphs with sub-pixel positioning
rparrett
pushed a commit
to rparrett/bevy
that referenced
this pull request
Jan 27, 2021
* cleanup unnecessary changes from PR bevyengine#1171 * add feature to correctly render glyphs with sub-pixel positioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed text render resolution for new text2d systems. Also attempts to address a shimmering effect where individual glyphs move slightly with respect to each other when animated.
without-fix.mp4
with-fix.mp4