Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase intensity of point light in async_compute example #11857

Closed
wants to merge 1 commit into from

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Feb 13, 2024

Objective

  • async_compute is very dark, lacking in detail.

Solution

  • Increase the intensity of the PointLight from it's default 800 lumens to 1,000,000 lumens.

Showcase

Before:

Before

After:

After

Changelog

  • Increased brightness of light in async_compute example.

Copy link
Contributor

@GitGhillie GitGhillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the PR should probably be something like "Increase the intensity of the PointLight in the async_compute example" since the light is already spawned (pedantic, I know)

@BD103 BD103 changed the title Spawn point light in async_compute example Increase intensity of point light in async_compute example Feb 14, 2024
@BD103
Copy link
Member Author

BD103 commented Feb 14, 2024

The title of the PR should probably be something like "Increase the intensity of the PointLight in the async_compute example" since the light is already spawned (pedantic, I know)

No, I agree. Since the PR titles get put into the patch notes, its best to be specific about that kind of thing. Changed! c:

@rparrett rparrett added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 14, 2024
@BD103
Copy link
Member Author

BD103 commented Feb 14, 2024

Rebased onto main. I tried switching from a hardcoded illuminance to light_consts::lux::DIRECT_SUNLIGHT introduced in #11581, but it still wasn't bright enough.

@doonv
Copy link
Contributor

doonv commented Feb 14, 2024

I tried switching from a hardcoded illuminance to light_consts::lux::DIRECT_SUNLIGHT introduced in #11581, but it still wasn't bright enough.

Point lights output in lumens, not lux. Lumens is the total amount of light emitted by a light, while lux is the amount of light an object is recieving.

@BD103
Copy link
Member Author

BD103 commented Feb 14, 2024

Point lights output in lumens, not lux. Lumens is the total amount of light emitted by a light, while lux is the amount of light an object is recieving.

Oh, that makes sense why it didn't work. 😆

@alice-i-cecile
Copy link
Member

Looks much better. @cart has been poking at this: I'll let him decide what to do to avoid creating subtle conflicts.

@afonsolage
Copy link
Contributor

As per #11868 the new default intensity for PointLight is already 1_000_000

@BD103
Copy link
Member Author

BD103 commented Feb 15, 2024

As per #11868 the new default intensity for PointLight is already 1_000_000

Ok, if #11868 gets merged then this can be closed.

@BD103 BD103 deleted the compute-light branch February 15, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants