bevy_input: fix repeated gamepad events #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if the actual value of LeftStickX was e.g. 0.034 and fluctuated a little bit (less than the threshold) it would repeatedly send out events, because it compared the value to the *filtered* old one - 0.0 - which is more then `0.01` (the threshold) away. The is fixed by first doing the deadzone and then comparing to the old value. Another possible solution would be to store both the actual old value and the filtered one, but that would add complexity.
jakobhellermann
force-pushed
the
fix-gamepad-threshold
branch
from
c59a0fe
to
2a0a040
Compare
rparrett
pushed a commit
to rparrett/bevy
that referenced
this pull request
Jan 27, 2021
Previously, if the actual value of LeftStickX was e.g. 0.034 and fluctuated a little bit (less than the threshold) it would repeatedly send out events, because it compared the value to the *filtered* old one - 0.0 - which is more then `0.01` (the threshold) away. The is fixed by first doing the deadzone and then comparing to the old value. Another possible solution would be to store both the actual old value and the filtered one, but that would add complexity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the actual value of
LeftStickXwas e.g. 0.034 and fluctuated a littlebit (less than the threshold) it would repeatedly send out events,
because it compared the value to the filtered old one - 0.0 - which is
more then
0.01(the threshold) away.The is fixed by first doing the deadzone and then comparing to the old
value.
Another possible solution would be to store both the actual old value
and the filtered one, but that would add complexity.