[Merged by Bors] - Add EventWriter #1575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Mar 6, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Mar 6, 2021
Ratysz
approved these changes
Mar 6, 2021
|
Yeah I think parity here is a good call. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 7, 2021
This adds a `EventWriter<T>` `SystemParam` that is just a thin wrapper around `ResMut<Events<T>>`. This is primarily to have API symmetry between the reader and writer, and has the added benefit of easily improving the API later with no breaking changes.
|
Pull request successfully merged into main. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
EventWriter<T>SystemParamthat is just a thin wrapper aroundResMut<Events<T>>. This is primarily to have API symmetry between the reader and writer, and has the added benefit of easily improving the API later with no breaking changes.