[Merged by Bors] - Add support for IndexFormat::Uint16 #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
alice-i-cecile
approved these changes
Oct 18, 2021
|
Would this need to be done at other place, like bevy/pipelined/bevy_pbr2/src/render/light.rs Line 805 in 432ce72 |
Good point, fixed. |
mockersf
approved these changes
Oct 18, 2021
alice-i-cecile
added
S-Ready-For-Final-Review
cart
force-pushed
the
16_bit_vertex_index_format
branch
from
f917756
to
ba8835a
Compare
|
just rebased / resolved conflicts. this looks good to me! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 28, 2021
# Objective while testing wgpu/WebGL on mobile GPU I've noticed bevy always forces vertex index format to 32bit (and ignores mesh settings). ## Solution the solution is to pass proper vertex index format in GpuIndexInfo to render_pass
|
Pull request successfully merged into pipelined-rendering. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
while testing wgpu/WebGL on mobile GPU I've noticed bevy always forces vertex index format to 32bit (and ignores mesh settings).
Solution
the solution is to pass proper vertex index format in GpuIndexInfo to render_pass