Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add MSAA to new renderer #3042

Closed
wants to merge 2 commits into from

Conversation

cart
Copy link
Member

@cart cart commented Oct 28, 2021

Adds support for MSAA to the new renderer. This is done using the new pipeline specialization support to specialize on sample count. This is an alternative implementation to #2541 that cuts out the need for complicated render graph edge management by moving the relevant target information into View entities. This reuses @superdump's clever MSAA bitflag range code from #2541.

Note that wgpu currently only supports 1 or 4 samples due to those being the values supported by WebGPU. However they do plan on exposing ways to enable/query for natively supported sample counts. When this happens we should integrate

@cart cart added the A-Rendering Drawing game state to the screen label Oct 28, 2021
@cart cart added this to the Bevy 0.6 milestone Oct 28, 2021
@cart
Copy link
Member Author

cart commented Oct 29, 2021

bors r+

bors bot pushed a commit that referenced this pull request Oct 29, 2021
Adds support for MSAA to the new renderer. This is done using the new [pipeline specialization](#3031) support to specialize on sample count. This is an alternative implementation to #2541 that cuts out the need for complicated render graph edge management by moving the relevant target information into View entities. This reuses @superdump's clever MSAA bitflag range code from #2541.

Note that wgpu currently only supports 1 or 4 samples due to those being the values supported by WebGPU. However they do plan on exposing ways to [enable/query for natively supported sample counts](gfx-rs/wgpu#1832). When this happens we should integrate
@bors
Copy link
Contributor

bors bot commented Oct 29, 2021

@bors bors bot changed the title Add MSAA to new renderer [Merged by Bors] - Add MSAA to new renderer Oct 29, 2021
@bors bors bot closed this Oct 29, 2021
bors bot pushed a commit that referenced this pull request Nov 3, 2021
Add an example that demonstrates the difference between no MSAA and MSAA 4x. This is also useful for testing panics when resizing the window using MSAA. This is on top of #3042 .

Co-authored-by: Carter Anderson <[email protected]>
bors bot pushed a commit that referenced this pull request Nov 3, 2021
Add an example that demonstrates the difference between no MSAA and MSAA 4x. This is also useful for testing panics when resizing the window using MSAA. This is on top of #3042 .

Co-authored-by: Carter Anderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants