Rename Assets::get_id_mut -> Assets::get_with_id_mut #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed to get_with_id_mut to be parallel with get_with_id.
ncallaway
force-pushed
the
cleanup/rename-get_id_mut
branch
from
71018bf
to
9616f14
Compare
karroffel
added
the
C-Code-Quality
|
Looks good to me. Thanks! |
mrk-its
pushed a commit
to mrk-its/bevy
that referenced
this pull request
Oct 6, 2020
Renamed to get_with_id_mut to be parallel with get_with_id.
|
@ncallaway please respond in #2373 for the relicense to MIT/Apache 2.0. Thanks! |
|
@DJMcNab Thanks for the poke, done |
|
Yay! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being proposed to make
get_with_id_mutmore parallel with the non-mutable versionget_with_id.This PR comes from the discussion on: #323