Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix doc_markdown lints in bevy_ui #3484

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix doc_markdown lints in bevy_ui #3484

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6d60f2
Fix doc_markdown lints in bevy_ui
mfdorst Dec 29, 2021
15d2ade
Unlink TextGlyph (not a type?)
mfdorst Dec 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions crates/bevy_ui/src/widget/text.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ fn scale_value(value: f32, factor: f64) -> f32 {
(value as f64 * factor) as f32
}

/// Defines how min_size, size, and max_size affects the bounds of a text
/// block.
/// Defines how `min_size`, `size`, and `max_size` affects the bounds of a text block.
pub fn text_constraint(min_size: Val, size: Val, max_size: Val, scale_factor: f64) -> f32 {
// Needs support for percentages
match (min_size, size, max_size) {
Expand All @@ -34,8 +33,8 @@ pub fn text_constraint(min_size: Val, size: Val, max_size: Val, scale_factor: f6
}
}

/// Computes the size of a text block and updates the TextGlyphs with the
/// new computed glyphs from the layout
/// Computes the size of a text block and updates the `TextGlyphs` with the new computed glyphs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a type named TextGlyphs (or TextGlyph). Not sure if this documentation is outdated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is outdated. We can fix that later though.

/// from the layout
#[allow(clippy::too_many_arguments, clippy::type_complexity)]
pub fn text_system(
mut queued_text: Local<QueuedText>,
Expand Down