Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Make many_cubes example more interesting #4015

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Make many_cubes example more interesting #4015

wants to merge 3 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Feb 22, 2022 •
edited
Loading

Objective

  • Make the many_cubes example more interesting (and look more like many_sprites)

Solution

  • Actually display many cubes
  • Move the camera around

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Feb 22, 2022
@mockersf mockersf added C-Examples An addition or correction to our examples and removed S-Needs-Triage This issue needs to be labelled labels Feb 22, 2022
alice-i-cecile
alice-i-cecile approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Random cube colors would also be nice for consistency and interest, but I'm unsure if that will affect performance.

@mockersf
Copy link
Member Author

added a light so that the cubes show their true color

many_cubes-light.mp4

@superdump superdump added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 3, 2022
@alice-i-cecile
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 3, 2022

Merge conflict.

@alice-i-cecile
Copy link
Member

@mockersf, can you rebase this when you get a chance?

@mockersf
Copy link
Member Author

mockersf commented Mar 4, 2022

done!

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 5, 2022
@mockersf
Make many_cubes example more interesting (#4015)
6c95b58 
# Objective

- Make the many_cubes example more interesting (and look more like many_sprites)

## Solution

- Actually display many cubes
- Move the camera around
@bors
Copy link
Contributor

bors bot commented Mar 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Make many_cubes example more interesting [Merged by Bors] - Make many_cubes example more interesting Mar 5, 2022
@bors bors bot closed this Mar 5, 2022
@DJMcNab
Copy link
Member

DJMcNab commented Mar 5, 2022

I hadn't seen this PR until it was merged, but I'm not sure I like this.

I just ran it now, and it's quite uncomfortable to watch. I only had it on for 700 frames apparently (31 seconds), and my eyes are still 'sore' almost 5 minutes later.

I'm not sure why that is, but I assume it's creating some nasty moiré patterns?

@alice-i-cecile
Copy link
Member

Fair. Perhaps we can make it less uncomfortable in a follow-up PR?

@mockersf
Copy link
Member Author

mockersf commented Mar 5, 2022

Sorry for that. I did find it a little dizzying, but that was fixed for my by adding a bigger cube to act as a reference point.

Would it work to slow down the camera rotations?

@mockersf
Copy link
Member Author

mockersf commented Mar 5, 2022 •
edited
Loading

I tried slowing down the camera and adding extra space between the cubes: https:/mockersf/bevy/tree/many-calm-cubes
Does that work for you?

@DJMcNab
Copy link
Member

DJMcNab commented Mar 5, 2022

So I just tried that branch, and get a similar feeling, although I think it might be less bad.

I think it would still be better as slower though. Unfortunately, I don't have any real suggestions for making it better :(

@alice-i-cecile
Copy link
Member

We could do very basic user-control perhaps? That would make it more useful as an example, but less useful as a quasi-benchmark.

@mockersf mockersf mentioned this pull request Mar 5, 2022
Closed
@mockersf
Copy link
Member Author

mockersf commented Mar 5, 2022 •
edited
Loading

I tried a few other things in #4117
From what I understand of moiré pattern, this should mostly break it up

bors bot pushed a commit that referenced this pull request Mar 5, 2022
@mockersf
Slow down the many_cubes example (#4117)
159fe52 
# Objective

- After #4015, the `many_cubes` example could introduce discomfort in some cases

## Solution

- Slow down the camera, add space between the cubes

https://user-images.githubusercontent.com/8672791/156898412-0fcd29b4-63b1-4e11-bf52-7ec40cb8f932.mp4
kurtkuehnert pushed a commit to kurtkuehnert/bevy that referenced this pull request Mar 6, 2022
@mockersf
Make many_cubes example more interesting (bevyengine#4015)
bf151d6 
# Objective

- Make the many_cubes example more interesting (and look more like many_sprites)

## Solution

- Actually display many cubes
- Move the camera around
kurtkuehnert pushed a commit to kurtkuehnert/bevy that referenced this pull request Mar 6, 2022
@mockersf
Slow down the many_cubes example (bevyengine#4117)
3c18991 
# Objective

- After bevyengine#4015, the `many_cubes` example could introduce discomfort in some cases

## Solution

- Slow down the camera, add space between the cubes

https://user-images.githubusercontent.com/8672791/156898412-0fcd29b4-63b1-4e11-bf52-7ec40cb8f932.mp4
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@mockersf @aevyrie
Make many_cubes example more interesting (bevyengine#4015)
281f2fb 
# Objective

- Make the many_cubes example more interesting (and look more like many_sprites)

## Solution

- Actually display many cubes
- Move the camera around
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@mockersf @aevyrie
Slow down the many_cubes example (bevyengine#4117)
141d057 
# Objective

- After bevyengine#4015, the `many_cubes` example could introduce discomfort in some cases

## Solution

- Slow down the camera, add space between the cubes

https://user-images.githubusercontent.com/8672791/156898412-0fcd29b4-63b1-4e11-bf52-7ec40cb8f932.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @alice-i-cecile @DJMcNab @superdump