Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - bevy_reflect_derive: Tidying up the code #4712

Closed
wants to merge 20 commits into from
Closed

[Merged by Bors] - bevy_reflect_derive: Tidying up the code #4712

wants to merge 20 commits into from

Commits on May 10, 2022

  1. Cleaned up reflection macros

    @MrGVSV
    MrGVSV committed May 10, 2022
    Configuration menu
    Copy the full SHA
    0c65b87 View commit details
    Browse the repository at this point in the history

  2. Add utility module

    @MrGVSV
    MrGVSV committed May 10, 2022
    Configuration menu
    Copy the full SHA
    4c3f1d6 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Nicola Papale <[email protected]>
    @MrGVSV @nicopap
    MrGVSV and nicopap authored May 10, 2022
    Configuration menu
    Copy the full SHA
    bd57543 View commit details
    Browse the repository at this point in the history

  4. Add StructField type

    @MrGVSV
    MrGVSV committed May 10, 2022
    Configuration menu
    Copy the full SHA
    c513157 View commit details
    Browse the repository at this point in the history

  5. Replace ignore's Option<bool> with plain bool

    @MrGVSV
    MrGVSV committed May 10, 2022
    Configuration menu
    Copy the full SHA
    e7604cf View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Add get_reflect_ident utility 

    Also made certain attributes into constants rather than hardcoded
strings.
    @MrGVSV
    MrGVSV committed May 11, 2022
    Configuration menu
    Copy the full SHA
    226405f View commit details
    Browse the repository at this point in the history

  2. Reduce nesting

    @MrGVSV
    MrGVSV committed May 11, 2022
    Configuration menu
    Copy the full SHA
    9708d36 View commit details
    Browse the repository at this point in the history

  3. Simplified match statement

    @MrGVSV
    MrGVSV committed May 11, 2022
    Configuration menu
    Copy the full SHA
    a15af0e View commit details
    Browse the repository at this point in the history

  4. Favor pub(crate) over pub for non-public items

    @MrGVSV
    MrGVSV committed May 11, 2022
    Configuration menu
    Copy the full SHA
    f5c0e10 View commit details
    Browse the repository at this point in the history

  5. Cleanup and documentation

    @MrGVSV
    MrGVSV committed May 11, 2022
    Configuration menu
    Copy the full SHA
    f5d651c View commit details
    Browse the repository at this point in the history

  6. Added direct path access to BevyManifest

    @MrGVSV
    MrGVSV committed May 11, 2022
    Configuration menu
    Copy the full SHA
    768750b View commit details
    Browse the repository at this point in the history

  7. Cleanup and docs for ReflectValueDef

    @MrGVSV
    MrGVSV committed May 11, 2022
    Configuration menu
    Copy the full SHA
    0c70b78 View commit details
    Browse the repository at this point in the history

  8. More cleanup

    @MrGVSV
    MrGVSV committed May 11, 2022
    Configuration menu
    Copy the full SHA
    1538bf9 View commit details
    Browse the repository at this point in the history

  9. Fix clippy errors

    @MrGVSV
    MrGVSV committed May 11, 2022
    Configuration menu
    Copy the full SHA
    a4d88ad View commit details
    Browse the repository at this point in the history

  10. Update to get_path_direct

    @MrGVSV
    MrGVSV committed May 11, 2022
    Configuration menu
    Copy the full SHA
    86d0b42 View commit details
    Browse the repository at this point in the history

  11. Add crate-level doc comment

    @MrGVSV
    MrGVSV committed May 11, 2022
    Configuration menu
    Copy the full SHA
    7b32e97 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. Rename type_uuid_derive -> derive_type_uuid for consistency

    @MrGVSV
    MrGVSV committed May 12, 2022
    Configuration menu
    Copy the full SHA
    7e2fcbe View commit details
    Browse the repository at this point in the history

  2. Changed macro function order 

    Now the order is: derive macros, attribute macros, then standard proc
macros.
    @MrGVSV
    MrGVSV committed May 12, 2022
    Configuration menu
    Copy the full SHA
    c72b56f View commit details
    Browse the repository at this point in the history

  3. Fix bevy_reflect_path bug 

    Removed all usages of `use #bevy_reflect_path`
    @MrGVSV
    MrGVSV committed May 12, 2022
    Configuration menu
    Copy the full SHA
    e77f20f View commit details
    Browse the repository at this point in the history

  4. Fix broken doc link

    @MrGVSV
    MrGVSV committed May 12, 2022
    Configuration menu
    Copy the full SHA
    ca2b137 View commit details
    Browse the repository at this point in the history