Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internalize task distinction into TaskPool #4740

Closed
wants to merge 108 commits into from
Closed

Internalize task distinction into TaskPool #4740

wants to merge 108 commits into from

Commits on May 13, 2022

  1. Internalize task distinction into TaskPool

    @james7132
    james7132 committed May 13, 2022
    Configuration menu
    Copy the full SHA
    aa75703 View commit details
    Browse the repository at this point in the history

  2. Basic priortization strategy

    @james7132
    james7132 committed May 13, 2022
    Configuration menu
    Copy the full SHA
    3f97865 View commit details
    Browse the repository at this point in the history

  3. Add missing docs

    @james7132
    james7132 committed May 13, 2022
    Configuration menu
    Copy the full SHA
    f0a70b9 View commit details
    Browse the repository at this point in the history

  4. Formatting

    @james7132
    james7132 committed May 13, 2022
    Configuration menu
    Copy the full SHA
    dadfe15 View commit details
    Browse the repository at this point in the history

  5. Fix WASM

    @james7132
    james7132 committed May 13, 2022
    Configuration menu
    Copy the full SHA
    3f260b2 View commit details
    Browse the repository at this point in the history

  6. Fix local tests for bevy_task

    @james7132
    james7132 committed May 13, 2022
    Configuration menu
    Copy the full SHA
    e35e11a View commit details
    Browse the repository at this point in the history

  7. Fix CI

    @james7132
    james7132 committed May 13, 2022
    Configuration menu
    Copy the full SHA
    2eab8fc View commit details
    Browse the repository at this point in the history

  8. Fix wasm32

    @james7132
    james7132 committed May 13, 2022
    Configuration menu
    Copy the full SHA
    02a36b5 View commit details
    Browse the repository at this point in the history

  9. Fix miri

    @james7132
    james7132 committed May 13, 2022
    Configuration menu
    Copy the full SHA
    76a2da0 View commit details
    Browse the repository at this point in the history

  10. More wasm32 tomfoolery

    @james7132
    james7132 committed May 13, 2022
    Configuration menu
    Copy the full SHA
    2a0ae14 View commit details
    Browse the repository at this point in the history

  11. Derp

    @james7132
    james7132 committed May 13, 2022
    Configuration menu
    Copy the full SHA
    c32bea7 View commit details
    Browse the repository at this point in the history

  12. Formatting woes

    @james7132
    james7132 committed May 13, 2022
    Configuration menu
    Copy the full SHA
    7911617 View commit details
    Browse the repository at this point in the history

  13. Fix up TaskPoolBuilder for wasm32

    @james7132
    james7132 committed May 13, 2022
    Configuration menu
    Copy the full SHA
    c3e4cff View commit details
    Browse the repository at this point in the history

  14. Remove unnecessary Send bounds

    @james7132
    james7132 committed May 13, 2022
    Configuration menu
    Copy the full SHA
    0b67525 View commit details
    Browse the repository at this point in the history

  15. More wasm woes

    @james7132
    james7132 committed May 13, 2022
    Configuration menu
    Copy the full SHA
    e87790e View commit details
    Browse the repository at this point in the history

  16. Formatting

    @james7132
    james7132 committed May 13, 2022
    Configuration menu
    Copy the full SHA
    8c722e3 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2022

  1. Use run instead custom run_forever

    @james7132
    james7132 committed May 14, 2022
    Configuration menu
    Copy the full SHA
    6ad621e View commit details
    Browse the repository at this point in the history

Commits on May 15, 2022

  1. Remove redundant "or" call

    @james7132
    james7132 committed May 15, 2022
    Configuration menu
    Copy the full SHA
    92e8bdf View commit details
    Browse the repository at this point in the history

  2. Use TaskGroup to specify target group instead

    @james7132
    james7132 committed May 15, 2022
    Configuration menu
    Copy the full SHA
    36dd177 View commit details
    Browse the repository at this point in the history

  3. Fix WASM

    @james7132
    james7132 committed May 15, 2022
    Configuration menu
    Copy the full SHA
    d8f9016 View commit details
    Browse the repository at this point in the history

  4. Relax WASM bounds

    @james7132
    james7132 committed May 15, 2022
    Configuration menu
    Copy the full SHA
    5d9f71d View commit details
    Browse the repository at this point in the history

  5. Remove more extra shutdown checks

    @james7132
    james7132 committed May 15, 2022
    Configuration menu
    Copy the full SHA
    ce9c9c7 View commit details
    Browse the repository at this point in the history

  6. Clean up thread builder code

    @james7132
    james7132 committed May 15, 2022
    Configuration menu
    Copy the full SHA
    67b3b5a View commit details
    Browse the repository at this point in the history

  7. Try removing miri cfg

    @james7132
    james7132 committed May 15, 2022
    Configuration menu
    Copy the full SHA
    e160839 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. Review fixes for single_threaded_task_pool

    @james7132
    james7132 committed May 16, 2022
    Configuration menu
    Copy the full SHA
    9b93347 View commit details
    Browse the repository at this point in the history

  2. Add error logs if running without any threads in a given group

    @james7132
    james7132 committed May 16, 2022
    Configuration menu
    Copy the full SHA
    291c09b View commit details
    Browse the repository at this point in the history

  3. Merge DefaultTaskPoolOptions in.

    @james7132
    james7132 committed May 16, 2022
    Configuration menu
    Copy the full SHA
    5123487 View commit details
    Browse the repository at this point in the history

  4. Fix CI

    @james7132
    james7132 committed May 16, 2022
    Configuration menu
    Copy the full SHA
    4ab2bf6 View commit details
    Browse the repository at this point in the history

  5. Update comment about priority

    @james7132
    james7132 committed May 16, 2022
    Configuration menu
    Copy the full SHA
    476a190 View commit details
    Browse the repository at this point in the history

  6. Add missing doc comment

    @james7132
    james7132 committed May 16, 2022
    Configuration menu
    Copy the full SHA
    f402434 View commit details
    Browse the repository at this point in the history

  7. More complete builder syntax for building TaskPool

    @james7132
    james7132 committed May 16, 2022
    Configuration menu
    Copy the full SHA
    3454585 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into task-pool-internalization

    @james7132
    james7132 committed May 16, 2022
    Configuration menu
    Copy the full SHA
    d33eb68 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. Review fixes

    @james7132
    james7132 committed May 18, 2022
    Configuration menu
    Copy the full SHA
    86d1b24 View commit details
    Browse the repository at this point in the history

  2. Remove clone

    @james7132
    james7132 committed May 18, 2022
    Configuration menu
    Copy the full SHA
    2f65f20 View commit details
    Browse the repository at this point in the history

  3. tick instead of try_tick

    @hymm
    hymm committed May 18, 2022
    Configuration menu
    Copy the full SHA
    a202d91 View commit details
    Browse the repository at this point in the history

  4. swap shutdown rx with ticker

    @hymm
    hymm committed May 18, 2022
    Configuration menu
    Copy the full SHA
    fedb3a4 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. Merge pull request #2 from hymm/pool-intern-experiment 

    Fix stealing
    @james7132
    james7132 authored May 19, 2022
    Configuration menu
    Copy the full SHA
    b6aa476 View commit details
    Browse the repository at this point in the history

  2. Add the early-out back in

    @james7132
    james7132 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    7d0235a View commit details
    Browse the repository at this point in the history

  3. Improve docs on TaskGroup, remove shortcuts

    @james7132
    james7132 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    9d1e974 View commit details
    Browse the repository at this point in the history

  4. Formatting

    @james7132
    james7132 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    c4cba7f View commit details
    Browse the repository at this point in the history

  5. Fix typo. 

    Co-authored-by: TheRawMeatball <[email protected]>
    @james7132 @TheRawMeatball
    james7132 and TheRawMeatball authored May 19, 2022
    Configuration menu
    Copy the full SHA
    deff027 View commit details
    Browse the repository at this point in the history

  6. Cleanup code

    @james7132
    james7132 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    94f6210 View commit details
    Browse the repository at this point in the history

  7. Fix WASM

    @james7132
    james7132 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    fe56295 View commit details
    Browse the repository at this point in the history

  8. Fix docs

    @james7132
    james7132 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    5af3e49 View commit details
    Browse the repository at this point in the history

  9. Fix WASM

    @james7132
    james7132 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    1ba48c6 View commit details
    Browse the repository at this point in the history

  10. YAWF: Yet another WASM fix

    @james7132
    james7132 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    ace8227 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. Review comments

    @james7132
    james7132 committed May 25, 2022
    Configuration menu
    Copy the full SHA
    8d3569a View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. Merge branch 'main' into task-pool-internalization

    @james7132
    james7132 committed May 26, 2022
    Configuration menu
    Copy the full SHA
    f077cfb View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Merge branch 'main' into task-pool-internalization

    @james7132
    james7132 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    3efc5a6 View commit details
    Browse the repository at this point in the history

  2. Revert scope executor changes

    @james7132
    james7132 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    b84fbba View commit details
    Browse the repository at this point in the history

  3. Review comments

    @james7132
    james7132 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    e26fc87 View commit details
    Browse the repository at this point in the history

  4. Update docs

    @james7132
    james7132 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    5b47ffb View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Embed async_executor into bevy_tasks

    @james7132
    james7132 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    b5fc0d2 View commit details
    Browse the repository at this point in the history

  2. Remove once_cell in the executor

    @james7132
    james7132 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    d5cb31c View commit details
    Browse the repository at this point in the history

  3. Use parking_lot over std locks

    @james7132
    james7132 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    610140a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'embed-async-executor' into task-pool-internalization

    @james7132
    james7132 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    1a7ce57 View commit details
    Browse the repository at this point in the history

  5. Internalize task prioritization into executor

    @james7132
    james7132 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    41067b2 View commit details
    Browse the repository at this point in the history

  6. Properly prioritize tasks in the executor

    @james7132
    james7132 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    cf0de23 View commit details
    Browse the repository at this point in the history

  7. Fix CI

    @james7132
    james7132 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    f2fda9b View commit details
    Browse the repository at this point in the history

  8. Fix WASM

    @james7132
    james7132 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    247b9cb View commit details
    Browse the repository at this point in the history

  9. Remove the unnecessary RwLock: we know how many runners we need

    @james7132
    james7132 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    fa997d9 View commit details
    Browse the repository at this point in the history

  10. A bit of code cleanup

    @james7132
    james7132 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    528493e View commit details
    Browse the repository at this point in the history

  11. Formatting

    @james7132
    james7132 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    0e55d7e View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Small cleanup, avoid overhead of Iterator::chain

    @james7132
    james7132 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    23e7372 View commit details
    Browse the repository at this point in the history

  2. Split out sleepers to properly notify them

    @james7132
    james7132 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    981d4ae View commit details
    Browse the repository at this point in the history

  3. Replace local queue Arcs with lifetimed references

    @james7132
    james7132 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    7fb8d25 View commit details
    Browse the repository at this point in the history

  4. Remove redundant State reference from Runner

    @james7132
    james7132 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    a67b7ff View commit details
    Browse the repository at this point in the history

  5. Remove the thread local lookup by embedding the RNG into the Runner

    @james7132
    james7132 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    96fdaf2 View commit details
    Browse the repository at this point in the history

  6. Attempt to directly write to a local queue before going to the global… 

    … queue
    @james7132
    james7132 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    ad2bae0 View commit details
    Browse the repository at this point in the history

  7. Avoid assert in hot loop while stealing

    @james7132
    james7132 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    6a4c0aa View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Merge branch 'main' into task-pool-internalization

    @james7132
    james7132 committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    8bf519c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into task-pool-internalization

    @james7132
    james7132 committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    cb4b57b View commit details
    Browse the repository at this point in the history

  3. Drop unused event-listener dependency

    @james7132
    james7132 committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    637fdc8 View commit details
    Browse the repository at this point in the history

  4. Revert directly writing to local queues

    @james7132
    james7132 committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    7deacd3 View commit details
    Browse the repository at this point in the history

  5. Small code cleanup

    @james7132
    james7132 committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    0fa8eb1 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Mix local and global queue fetches by priority

    @james7132
    james7132 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    9bfa2d0 View commit details
    Browse the repository at this point in the history

  2. Remove active slab

    @james7132
    james7132 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    a3bed82 View commit details
    Browse the repository at this point in the history

  3. Formatting

    @james7132
    james7132 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    c3f014f View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary indexing when ticking

    @james7132
    james7132 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    018adfd View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2022

  1. Cleanup: Reduce LocalExecutor to a single queue

    @james7132
    james7132 committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    189c53d View commit details
    Browse the repository at this point in the history

  2. Remove the unsafe unwrap_unchecked without a good perf reason

    @james7132
    james7132 committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    560ff25 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. Remove atomics from Runner

    @james7132
    james7132 committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    1ada122 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into task-pool-internalization

    @james7132
    james7132 committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    4c1f26f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'less-atomics' into task-pool-internalization

    @james7132
    james7132 committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    67c866b View commit details
    Browse the repository at this point in the history

  4. Fix certain thread groups not being used. Add throttling.

    @james7132
    james7132 committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    5a2de23 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Use st3 for local queues and work-stealing

    @james7132
    james7132 committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    38d9936 View commit details
    Browse the repository at this point in the history

  2. Only notify when stealing after a search

    @james7132
    james7132 committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    bc469af View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. Refactor search throttling

    @james7132
    james7132 committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    bba24f1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into task-pool-internalization

    @james7132
    james7132 committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    a0f139e View commit details
    Browse the repository at this point in the history

  3. Formatting

    @james7132
    james7132 committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    b34b5f6 View commit details
    Browse the repository at this point in the history

  4. Shut up clippy

    @james7132
    james7132 committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    93134c8 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. Limit lower priority stealing and notifications

    @james7132
    james7132 committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    2178238 View commit details
    Browse the repository at this point in the history

  2. Replace the async_channel dependency with a lower level event_listener

    @james7132
    james7132 committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    71822ee View commit details
    Browse the repository at this point in the history

  3. Split out LocalExecutor into it's own file. Shrink dependencies on wa… 

    …sm32
    @james7132
    james7132 committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    5f99996 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Merge branch 'main' into task-pool-internalization

    @james7132
    james7132 committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    acf56cf View commit details
    Browse the repository at this point in the history

  2. Formatting

    @james7132
    james7132 committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    558db08 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2022

  1. Merge branch 'main' into task-pool-internalization

    @james7132
    james7132 committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    310c3b9 View commit details
    Browse the repository at this point in the history

  2. Attempt to fix CI

    @james7132
    james7132 committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    0ca76c9 View commit details
    Browse the repository at this point in the history

  3. Update st3

    @james7132
    james7132 committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    1378672 View commit details
    Browse the repository at this point in the history

  4. Use let-else

    @james7132
    james7132 committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    994a250 View commit details
    Browse the repository at this point in the history

  5. Fix locality tests

    @james7132
    james7132 committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    18d2a8f View commit details
    Browse the repository at this point in the history

  6. Fix CI

    @james7132
    james7132 committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    9cb309b View commit details
    Browse the repository at this point in the history

  7. Fix WASM

    @james7132
    james7132 committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    b4f700c View commit details
    Browse the repository at this point in the history

  8. Make LocalExecutor not require atomics

    @james7132
    james7132 committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    30aad1e View commit details
    Browse the repository at this point in the history

  9. Add simple executor to avoid using Executor in scope

    @james7132
    james7132 committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    2b0d2d7 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Clean up thread spawn logic

    @james7132
    james7132 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    c380b57 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into task-pool-internalization

    @james7132
    james7132 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    9be6fe2 View commit details
    Browse the repository at this point in the history

  3. Formatting

    @james7132
    james7132 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    07e1acf View commit details
    Browse the repository at this point in the history