Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix size_hint for partially consumed QueryIter and QueryCombinationIter #5214

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Fix size_hint for partially consumed QueryIter and QueryCombinationIter #5214

wants to merge 4 commits into from

Commits on Nov 1, 2022

  1. Fix size_hint for partially consumed QueryIter 

    Instead of returning the total count of elements in the `QueryIter` in
`size_hint`, we return the count of remaining elements in it. This
Fixes bevyengine#5149. This is also true of `QueryCombinationIter`.

- bevyengine#5149
- bevyengine#5148
    @nicopap
    nicopap committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    3880ef5 View commit details
    Browse the repository at this point in the history

  2. Fix comment note 

    Co-authored-by: Alice Cecile <[email protected]>
    @nicopap @alice-i-cecile
    nicopap and alice-i-cecile committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    1c0b66d View commit details
    Browse the repository at this point in the history

  3. Rename remaning to be more explicit

    @nicopap
    nicopap committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    5ef7e5c View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Swap back binomial formula arguments

    @nicopap
    nicopap authored Nov 15, 2022
    Configuration menu
    Copy the full SHA
    ce115ff View commit details
    Browse the repository at this point in the history