Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Implement Debug for Gamepads #5291

Closed

Conversation

alice-i-cecile
Copy link
Member

Generally a good idea.

I ran into this because I wanted to store Gamepads in a wrapper struct in Leafwing-Studios/leafwing-input-manager#168.

This PR allows the Debug derive used there to continue working. I could workaround this with a custom impl, but a PR upstream seemed like the right fix.

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Input Player input via keyboard, mouse, gamepad, and more labels Jul 12, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 13, 2022
@alice-i-cecile
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 13, 2022
Generally a good idea.

I ran into this because I wanted to store `Gamepads` in a wrapper struct in Leafwing-Studios/leafwing-input-manager#168. 

This PR allows the `Debug` derive used there to continue working. I could workaround this with a custom impl, but a PR upstream seemed like the right fix.
@bors
Copy link
Contributor

bors bot commented Jul 13, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jul 13, 2022
Generally a good idea.

I ran into this because I wanted to store `Gamepads` in a wrapper struct in Leafwing-Studios/leafwing-input-manager#168. 

This PR allows the `Debug` derive used there to continue working. I could workaround this with a custom impl, but a PR upstream seemed like the right fix.
@bors bors bot changed the title Implement Debug for Gamepads [Merged by Bors] - Implement Debug for Gamepads Jul 13, 2022
@bors bors bot closed this Jul 13, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
Generally a good idea.

I ran into this because I wanted to store `Gamepads` in a wrapper struct in Leafwing-Studios/leafwing-input-manager#168. 

This PR allows the `Debug` derive used there to continue working. I could workaround this with a custom impl, but a PR upstream seemed like the right fix.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
Generally a good idea.

I ran into this because I wanted to store `Gamepads` in a wrapper struct in Leafwing-Studios/leafwing-input-manager#168. 

This PR allows the `Debug` derive used there to continue working. I could workaround this with a custom impl, but a PR upstream seemed like the right fix.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
Generally a good idea.

I ran into this because I wanted to store `Gamepads` in a wrapper struct in Leafwing-Studios/leafwing-input-manager#168. 

This PR allows the `Debug` derive used there to continue working. I could workaround this with a custom impl, but a PR upstream seemed like the right fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants