Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to wgpu-rs 0.7 #542

Merged
merged 22 commits into from
Feb 1, 2021
Merged

Update to wgpu-rs 0.7 #542

merged 22 commits into from
Feb 1, 2021

Conversation

Neo-Zhixing
Copy link
Contributor

@Neo-Zhixing Neo-Zhixing commented Sep 21, 2020 •
edited
Loading

This PR makes bevy's renderer compatible with upstream wgpu-rs .

Wait to merge this until wgpu-rs's next release.

@Neo-Zhixing Neo-Zhixing mentioned this pull request Sep 21, 2020
Closed
@karroffel karroffel added A-Build-System Related to build systems or continuous integration A-Rendering Drawing game state to the screen C-Dependencies A change to the crates that Bevy depends on labels Sep 21, 2020
@verzuz verzuz mentioned this pull request Sep 21, 2020
Closed
@Neo-Zhixing Neo-Zhixing mentioned this pull request Sep 24, 2020
Closed
@Neo-Zhixing Neo-Zhixing changed the title Use upstream wgpu-rs for PolygonMode support Update to wgpu-rs 0.7 Jan 26, 2021
@Neo-Zhixing Neo-Zhixing marked this pull request as ready for review January 26, 2021 02:14
cart
cart reviewed Jan 31, 2021
View reviewed changes
Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for doing this. I pushed one small change removing PipelineDescriptor::index_format. strip_index_format has replaced it. We now specialize on that.

crates/bevy_render/src/shader/shader_reflect.rs Outdated Show resolved Hide resolved
crates/bevy_wgpu/src/wgpu_renderer.rs Outdated Show resolved Hide resolved
crates/bevy_render/src/pipeline/pipeline_compiler.rs Outdated Show resolved Hide resolved
crates/bevy_render/src/pipeline/pipeline_layout.rs Outdated Show resolved Hide resolved
crates/bevy_wgpu/src/renderer/wgpu_render_resource_context.rs Show resolved Hide resolved
@Neo-Zhixing
Copy link
Contributor Author

wgpu 0.7 was just released! 🎉🎉🎉🎉

This PR is now ready to be merged.

@cart
Copy link
Member

cart commented Feb 1, 2021

Awesome!

@cart cart merged commit 81809c7 into bevyengine:master Feb 1, 2021
@cart cart mentioned this pull request Feb 1, 2021
Closed
bors bot pushed a commit that referenced this pull request Mar 3, 2021
@verzuz @cart
enable wgpu device features (#547)
b8961a9 
Should wait for #542 and new wgpu_rs release.

Co-authored-by: Carter Anderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart left review comments

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration A-Rendering Drawing game state to the screen C-Dependencies A change to the crates that Bevy depends on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neo-Zhixing @cart @karroffel