Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix Quat type name in scene example scene file #5803

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix Quat type name in scene example scene file #5803

wants to merge 1 commit into from

Conversation

tguichaoua
Copy link
Contributor

Objective

fix #5790

Solution

Change type name in the scene file by its new name glam::f32::sse2::quat::Quat.

@djeedai
Copy link
Contributor

djeedai commented Aug 26, 2022

As noted by @DJMcNab in #5790 (as I understand) this is the wrong fix.

@djeedai djeedai added C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples labels Aug 26, 2022
@tguichaoua
Copy link
Contributor Author

#5805 is a more generic fix to this kind of problem.

cart
cart approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we really need something like #5805. While we wait, I think its better to bet on sse2 existing than not existing, so im inclined to merge this.

@cart
Copy link
Member

cart commented Aug 29, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 29, 2022
@tguichaoua
fix Quat type name in scene example scene file (#5803)
e8439bf 
# Objective

fix #5790 

## Solution

Change type name in the scene file by its new name `glam::f32::sse2::quat::Quat`.
@bors
Copy link
Contributor

bors bot commented Aug 30, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title fix Quat type name in scene example scene file [Merged by Bors] - fix Quat type name in scene example scene file Aug 30, 2022
@bors bors bot closed this Aug 30, 2022
@tguichaoua tguichaoua deleted the fix_5790 branch August 30, 2022 12:03
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@tguichaoua @james7132
fix Quat type name in scene example scene file (bevyengine#5803)
608ca0b 
# Objective

fix bevyengine#5790 

## Solution

Change type name in the scene file by its new name `glam::f32::sse2::quat::Quat`.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@tguichaoua @ItsDoot
fix Quat type name in scene example scene file (bevyengine#5803)
1c7a55e 
# Objective

fix bevyengine#5790 

## Solution

Change type name in the scene file by its new name `glam::f32::sse2::quat::Quat`.
@mockersf mockersf mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart approved these changes

Assignees
No one assigned
Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to Load Quat Type for Scene Example
3 participants
@tguichaoua @djeedai @cart