Allow custom depth texture usage #6815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neo-Zhixing
commented
Dec 1, 2022
| } | ||
|
|
||
| #[derive(Clone, Copy, Reflect)] | ||
| pub struct Camera3dDepthTextureUsage(u32); |
There was a problem hiding this comment.
Creating a custom class to wrap the TextureUsage so that it implements Reflect
james7132
added
C-Feature
IceSentry
approved these changes
Dec 10, 2022
kurtkuehnert
approved these changes
Jan 14, 2023
|
@superdump Can you merge this PR? |
|
Bump |
|
Bump :) |
mockersf
reviewed
Mar 21, 2023
| #[extract_component_filter(With<Camera>)] | ||
| #[reflect(Component)] | ||
| pub struct Camera3d { | ||
| /// The clear color operation to perform for the main 3d pass. | ||
| pub clear_color: ClearColorConfig, | ||
| /// The depth clear operation to perform for the main 3d pass. | ||
| pub depth_load_op: Camera3dDepthLoadOp, | ||
| /// The texture usages for the depth texture created for the main 3d pass. | ||
| pub depth_texture_usages: Camera3dDepthTextureUsage, |
There was a problem hiding this comment.
what happens if I set a value without TextureUsages::RENDER_ATTACHMENT here? Should we consider it's present even if the user didn't set it?
There was a problem hiding this comment.
imo the user should be allowed to set a value without TextureUsages::RENDER_ATTACHMENT. If they explicitly opted out of the RENDER_ATTACHMENT usage, there's probably a reason for it.
IceSentry
suggested changes
Mar 22, 2023
IceSentry
approved these changes
May 4, 2023
IceSentry
added
the
S-Ready-For-Final-Review
cart
approved these changes
May 8, 2023
This was referenced Jun 28, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
# Objective - Some users want to change the default texture usage of the main camera but they are currently hardcoded ## Solution - Add a component that is used to configure the main texture usage field --- ## Changelog Added `CameraMainTextureUsage` Added `CameraMainTextureUsage` to `Camera3dBundle` and `Camera2dBundle` ## Migration Guide Add `main_texture_usages: Default::default()` to your camera bundle. # Notes Inspired by: #6815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Sometimes we might want to read from the depth texture in some custom rendering features. We must then add
STORAGE_BINDINGorTEXTURE_BINDINGto the texture usage flags when creating them.Solution
This PR allows one to customize the usage flags in the
Camera3dcomponent.