Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix min and max size using size value #7948

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Mar 7, 2023

Objective

Fixes #7946

Solution

Fixed what seems to be a copy/paste error and things started to work.

@rparrett rparrett added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets labels Mar 7, 2023
@alice-i-cecile
Copy link
Member

Ping @ickshonpe for review :) (Bug Cart to be added to the org so I can request reviews properly?)

@alice-i-cecile alice-i-cecile added this to the 0.10.1 milestone Mar 7, 2023
Copy link
Contributor

@ickshonpe ickshonpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this was me.

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 7, 2023
@ickshonpe
Copy link
Contributor

😦 I'll write some tests.

@james7132 james7132 added this pull request to the merge queue Mar 7, 2023
Merged via the queue into bevyengine:main with commit 54dec60 Mar 7, 2023
Merged via the queue into bevyengine:main with commit af74d21 Mar 7, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@nicoburns
Copy link
Contributor

@cart Is there a timeline for a bevy 0.10.1 release? #8169 is the fourth report we've had of this particular issue. IMO it might be worth putting out a 0.10.1 release with just this commit cherry-picked if a full patch release isn't going to be soon. Probably wouldn't even need to bother with release notes, etc if you wanted to keep the amount of work this requires down.

For context, the bug here is a silly typo when translating Bevy UI styles into Taffy styles that sets the min_size and max_size styles in Taffy to the value of the size style set in Bevy (instead of the corresponding min_size and max_size styles in Bevy). This completely breaks any UIs that use min or max sizes (and I think even UIs that just use width/height where those UIs rely on flex-shrinking).

@cart
Copy link
Member

cart commented Mar 23, 2023

No specific timeline (other than before Bevy Jam #3), but this does make me want to release sooner rather than later. I'll look into the state of things.

@nicoburns
Copy link
Contributor

No specific timeline (other than before Bevy Jam #3), but this does make me want to release sooner rather than later. I'll look into the state of things.

"before Bevy Jam 3" would be in the next week or so anyway? If so, then that seems plenty soon enough to me :) Definitely be good to get this sorted before the Jam!

@jkb0o jkb0o mentioned this pull request Mar 24, 2023
mockersf pushed a commit that referenced this pull request Mar 27, 2023
Sjael pushed a commit to Sjael/bevy that referenced this pull request Feb 5, 2024
patrickariel pushed a commit to patrickariel/bevy that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nodes are not constrained to container
7 participants