Make standard commands more ergonomic (in niche cases) #8249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
I ran into a case where I need to create a
CommandQueue
and push standardCommand
actions likeInsert
orRemove
to it manually. I saw thatRemove
looked as follows:so naturally, I tried to use
Remove::<Foo>::from(entity)
but it didn't exist. We need to specify thePhantomData
explicitly when creating this command action. The same goes forRemoveResource
andInitResource
Solution
This PR implements the following:
From<Entity>
forRemove<T>
Default
forRemoveResource
andInitResource
Commands
phantom
field on the structs above to_phantom
to have a more uniform field naming scheme for the command actionsChangelog
From<Entity>
forRemove<T>
andDefault
forRemoveResource
andInitResource
for ergonomics