Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove base set error variants of ScheduleBuildError #8269

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Remove base set error variants of ScheduleBuildError #8269

merged 1 commit into from
Mar 30, 2023

Conversation

geieredgar
Copy link
Contributor

Objective

With the removal of base sets, some variants of ScheduleBuildError can never occur and should be removed.

Solution

  • Remove the obsolete variants of ScheduleBuildError.
  • Also fix a doc comment which mentioned base sets.

Changelog

Removed

  • Remove ScheduleBuildError::SystemInMultipleBaseSets and ScheduleBuildError::SetInMultipleBaseSets.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Mar 30, 2023
@alice-i-cecile alice-i-cecile added this to the 0.11 milestone Mar 30, 2023
@alice-i-cecile alice-i-cecile added the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Mar 30, 2023
@github-actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

@james7132 james7132 added this pull request to the merge queue Mar 30, 2023
Merged via the queue into bevyengine:main with commit a1d771a Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.
3 participants
@geieredgar @alice-i-cecile @james7132