Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve safety for the multi-threaded executor using UnsafeWorldCell #8292

Merged
merged 33 commits into from
May 29, 2023
Merged

Improve safety for the multi-threaded executor using UnsafeWorldCell #8292

merged 33 commits into from
May 29, 2023

Commits on Apr 2, 2023

  1. use UnsafeWorldCell for system impls

    @JoJoJet
    JoJoJet committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    6816767 View commit details
    Browse the repository at this point in the history

  2. add ReadOnlySystem::run_read_only

    @JoJoJet
    JoJoJet committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    6c25b97 View commit details
    Browse the repository at this point in the history

  3. validate world in run_read_only

    @JoJoJet
    JoJoJet committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    ea4f902 View commit details
    Browse the repository at this point in the history

  4. use UnsafeWorldCell in the system executor

    @JoJoJet
    JoJoJet committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    87f267f View commit details
    Browse the repository at this point in the history

  5. use elided lifetimes in the system executor

    @JoJoJet
    JoJoJet committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    f7ff99d View commit details
    Browse the repository at this point in the history

  6. remove an unnecessary unsafe block

    @JoJoJet
    JoJoJet committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    bf82d9d View commit details
    Browse the repository at this point in the history

  7. improve docs for run_read_only

    @JoJoJet
    JoJoJet committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    6f73a7d View commit details
    Browse the repository at this point in the history

  8. modify safety invariants for System::run_unsafe

    @JoJoJet
    JoJoJet committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    f026dd2 View commit details
    Browse the repository at this point in the history

  9. tweak some phrasing

    @JoJoJet
    JoJoJet committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    46a44a5 View commit details
    Browse the repository at this point in the history

  10. simplify a condition-folding invariant

    @JoJoJet
    JoJoJet committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    9b30215 View commit details
    Browse the repository at this point in the history

  11. improve safety invariants in the executor

    @JoJoJet
    JoJoJet committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    df64a3c View commit details
    Browse the repository at this point in the history

  12. use a more appropriate world access function

    @JoJoJet
    JoJoJet committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    d8e70b4 View commit details
    Browse the repository at this point in the history

  13. return Tick from `UnsafeWorldCell::increment_change_tick

    @JoJoJet
    JoJoJet committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    6e036cd View commit details
    Browse the repository at this point in the history

  14. fix lifetimes

    @JoJoJet
    JoJoJet committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    0fb60ca View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. improve docs for System::run

    @JoJoJet
    JoJoJet committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    21066eb View commit details
    Browse the repository at this point in the history

  2. make condition evaluation function unsafe

    @JoJoJet
    JoJoJet committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    a1d47d3 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into system-unsafe-world… 

    …-cell
    @JoJoJet
    JoJoJet committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    c621dc4 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Merge remote-tracking branch 'upstream/main' into system-unsafe-world… 

    …-cell
    @JoJoJet
    JoJoJet committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    106ae64 View commit details
    Browse the repository at this point in the history

  2. add UnsafeWorldCell::id

    @JoJoJet
    JoJoJet committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    0cd81e8 View commit details
    Browse the repository at this point in the history

  3. use UnsafeWorldCell for update_archetype_component_access

    @JoJoJet
    JoJoJet committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    2da604f View commit details
    Browse the repository at this point in the history

  4. update callsites in doctests

    @JoJoJet
    JoJoJet committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    3eedf5c View commit details
    Browse the repository at this point in the history

  5. split an unsafe block

    @JoJoJet
    JoJoJet committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    9b934c0 View commit details
    Browse the repository at this point in the history

  6. update some benchmarks

    @JoJoJet
    JoJoJet committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    432d6d7 View commit details
    Browse the repository at this point in the history

  7. tweak a safety comment

    @JoJoJet
    JoJoJet committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    07f9302 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Merge remote-tracking branch 'upstream/main' into system-unsafe-world… 

    …-cell
    @JoJoJet
    JoJoJet committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    c32b69b View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. simplify impl SystemParam for WorldId

    @JoJoJet
    JoJoJet committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    59dd4b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Merge remote-tracking branch 'upstream/main' into system-unsafe-world… 

    …-cell
    @JoJoJet
    JoJoJet committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    a3d537d View commit details
    Browse the repository at this point in the history

  2. fix formatting for a comment

    @JoJoJet
    JoJoJet committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    840dd95 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. remove an apostrophe

    @JoJoJet
    JoJoJet committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    02334b5 View commit details
    Browse the repository at this point in the history

  2. rephrase a safety comment

    @JoJoJet
    JoJoJet committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    2615867 View commit details
    Browse the repository at this point in the history

  3. rephrase another safety comment

    @JoJoJet
    JoJoJet committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    702f09f View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Apply suggestions from code review 

    Co-authored-by: James Liu <[email protected]>
    @JoJoJet @james7132
    JoJoJet and james7132 authored May 9, 2023
    Configuration menu
    Copy the full SHA
    5e11ad5 View commit details
    Browse the repository at this point in the history

  2. Update crates/bevy_ecs/src/schedule/executor/multi_threaded.rs

    @JoJoJet
    JoJoJet authored May 9, 2023
    Configuration menu
    Copy the full SHA
    4e6630d View commit details
    Browse the repository at this point in the history