Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow bevy_ui crate to compile without the text feature enabled #8437

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Allow bevy_ui crate to compile without the text feature enabled #8437

merged 1 commit into from
Apr 18, 2023

Conversation

nicoburns
Copy link
Contributor

Objective

Allow bevy_ui crate to compile without the text feature enabled

Solution

  • Correctly conditionally compile text_system

@nicoburns nicoburns added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets P-Regression Functionality that used to work but no longer does. Add a test for this! labels Apr 18, 2023
@nicoburns nicoburns added this to the 0.11 milestone Apr 18, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 18, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 18, 2023
Merged via the queue into bevyengine:main with commit 5ed6b62 Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.
2 participants
@nicoburns @alice-i-cecile