Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
ahash
andhashbrown
Solution
This is a breaking change because we were creating two fixed hashers with
AHasher::new_with_keys
, which was a method that existed only for testing purpose and has been removed from public.I replaced it with
RandomState::with_seeds
which is the proper way to get a fixed hasher (see this table). This means that hashes won't be the same across versionsMigration Guide