Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Material2d pipeline systems public #8642

Merged
merged 1 commit into from
May 23, 2023
Merged

Make Material2d pipeline systems public #8642

merged 1 commit into from
May 23, 2023

Conversation

tinrab
Copy link
Contributor

@tinrab tinrab commented May 20, 2023 •
edited
Loading

Objective

Make Material2dPipeline reusable. This was already done for PBR materials in #7548.

Solution

Expose extract_materials_2d, prepare_materials_2d and ExtractedMaterials2d.

Changelog

  • bevy_sprite: Make prepare_materials_2d, extract_materials_2d and ExtractedMaterials2d public.

@github-actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@nicopap nicopap added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use labels May 21, 2023
nicopap
nicopap approved these changes May 21, 2023
View reviewed changes
Copy link
Contributor

@nicopap nicopap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could you add the following to your PR description?

---

## Changelog

- bevy_sprite: Make `prepare_materials_2d`, `extract_materials_2d` and `ExtractedMaterials2d` public.

@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 21, 2023
@james7132 james7132 added this to the 0.11 milestone May 21, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 23, 2023
Merged via the queue into bevyengine:main with commit 335afbf May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@nicopap nicopap nicopap approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.
4 participants
@tinrab @james7132 @nicopap @alice-i-cecile