Replace converters functions in favor of the From trait #8660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_winit/converters.rs
file contains many converter functions who's functionality could be achieved by implementing theFrom
trait on the respective enums/structs..into()
method for the aforementioned enums/structs.From
implementations, then this PR should be closed.Solution
Added the following trait implementations:
impl From<winit::event::KeyboardInput> for KeyboardInput
impl From<winit::event::VirtualKeyCode> for KeyCode
impl From<winit::event::ElementState> for ButtonState
impl From<winit::event::MouseButton> for MouseButton
impl From<CursorIcon> for winit::window::CursorIcon
impl From<WindowLevel> for winit::window::WindowLevel
To support this change, the
winit
crate must be added as a dependency inbevy_input
andbevy_window
crates.