Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(asset): fix asset trait example #9105

Merged
merged 2 commits into from
Jul 11, 2023
Merged

doc(asset): fix asset trait example #9105

merged 2 commits into from
Jul 11, 2023

Conversation

tguichaoua
Copy link
Contributor

Objective

Fix the example code for the Asset trait.

Solution

Add TypePath trait on CustomAsset.
Add a static check.

tguichaoua and others added 2 commits July 10, 2023 22:22
@tguichaoua
doc(asset): fix Asset trait example
5790859 
In the example, the `TypePath` trait was missing.
@tguichaoua
add a check
ecaaaa1
@tguichaoua tguichaoua changed the title doc(asse): fix asset trait example doc(asset): fix asset trait example Jul 10, 2023
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Assets Load files from disk to use for things like images, models, and sounds C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed C-Bug An unexpected or incorrect behavior labels Jul 11, 2023
@james7132 james7132 added this pull request to the merge queue Jul 11, 2023
@mockersf mockersf added this to the 0.11.1 milestone Jul 11, 2023
Merged via the queue into bevyengine:main with commit cd0a642 Jul 11, 2023
25 checks passed
@tguichaoua tguichaoua deleted the doc/asset/fix_asset_trait_example branch July 12, 2023 09:00
cart pushed a commit that referenced this pull request Aug 10, 2023
@tguichaoua @cart
doc(asset): fix asset trait example (#9105)
d5f6d92 
# Objective

Fix the example code for the `Asset` trait.

## Solution

Add `TypePath` trait on `CustomAsset`.
Add a static check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.11.1
Development

Successfully merging this pull request may close these issues.
4 participants
@tguichaoua @james7132 @alice-i-cecile @mockersf