Fix panic whilst loading UASTC encoded ktx2 textures #9158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #9121
Context:
ImageTextureLoader
depends onRenderDevice
to work out which compressed image formats it can supportRenderDevice
is initialised byRenderPlugin
RenderPlugin
initialisation asyncRenderDevice
to be missing at the time ofImageTextureLoader
initialisation, which in turn meant UASTC encoded ktx2 textures were being converted to unsupported formats, and thus caused panicsSolution
ImageTextureLoader
initialisationChangelog
ImageTextureLoader
initialisation fromImagePlugin::build()
toImagePlugin::finish()
CompressedImageFormats::NONE
ifRenderDevice
resource is missing