Fix ambiguous_with
breaking run conditions
#9253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
ambiguous_with
breaks run conditions #9114Solution
Inside
ScheduleGraph::build_schedule()
the variablenode_count = self.systems.len() + self.system_sets.len()
is used to calculate the indices for thereachable
bitset derived fromself.hierarchy.graph
. However, the number of nodes insideself.hierarchy.graph
does not always correspond toself.systems.len() + self.system_sets.len()
whenambiguous_with
is used, because an ambiguous set is added tosystem_sets
(because we need anNodeId
for the ambiguity graph) without adding a node toself.hierarchy
.In this PR, we rename
node_count
to the more descriptive namehg_node_count
and set it toself.hierarchy.graph.node_count()
.