Replace DiagnosticId
by DiagnosticPath
#9266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Implements #9216
Solution
DiagnosticId
byDiagnosticPath
. It's pre-hashed usingconst-fnv1a-hash
crate, so it's possible to create path in const contexts.Changelog
Replaced
DiagnosticId
byDiagnosticPath
Set default history length to 120 measurements (2 seconds on 60 fps).
I've noticed hardcoded constant 20 everywhere and decided to change it to
DEFAULT_MAX_HISTORY_LENGTH
, which is set to new diagnostics by default. To override it, usewith_max_history_length
.Migration Guide