Fixed: Default window is now "App" instead of "Bevy App" #9301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
Selene-Amanita
added
A-Windowing
Selene-Amanita
approved these changes
Jul 29, 2023
Aceeri
approved these changes
Jul 29, 2023
Selene-Amanita
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Jul 29, 2023
cart
pushed a commit
that referenced
this pull request
Aug 10, 2023
# Objective Fixes #9298 - Default window title leaks "bevy" context ## Solution I just replaced the literal string "Bevy App" with "App" in Window's Default trait implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #9298 - Default window title leaks "bevy" context
Solution
I just replaced the literal string "Bevy App" with "App" in Window's Default trait implementation.