Manual "Reflect Value" AssetPath impl to fix dynamic linking #9752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix #9747
Solution
Linkers don't like what we're doing with CowArc (I'm guessing it has something to do with
?Sized
). Weirdly theReflect
derive onAssetPath
doesn't fail, despiteCowArc
not implementingReflect
.To resolve this, we manually implement "reflect value" for
AssetPath<'static>
. It sadly cannot useimpl_reflect_value
because that macro doesn't support static lifetimes.