Implement Reflect for Mesh
#9779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicopap
reviewed
Sep 12, 2023
| primitive_topology: PrimitiveTopology, | ||
| /// `std::collections::BTreeMap` with all defined vertex attributes (Positions, Normals, ...) | ||
| /// for this mesh. Attribute ids to attribute values. | ||
| /// Uses a BTreeMap because, unlike HashMap, it has a defined iteration order, | ||
| /// which allows easy stable VertexBuffers (i.e. same buffer order) | ||
| #[reflect(ignore)] | ||
| attributes: BTreeMap<MeshVertexAttributeId, MeshAttributeData>, |
There was a problem hiding this comment.
If you feel like it I don't see anything preventing anyone from implementing Reflect on PrimitiveTopology and MeshAttributeData.
nicopap
added
C-Feature
nicopap
approved these changes
Sep 12, 2023
alice-i-cecile
approved these changes
Sep 12, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective - I want to associate `TypeData` with `Mesh`, to make it editable/inspectable in my reflection-based editor. `Mesh` has to implement `Reflect` for that. The precise reflection behavior does not matter. ## Solution - `#[derive(Reflect)]`, ignore fields whose types aren't reflectable. - Call `App::register_asset_reflect` in the `MeshPlugin`. --- ## Changelog - `Mesh` now implements `Reflect`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
TypeDatawithMesh, to make it editable/inspectable in my reflection-based editor.Meshhas to implementReflectfor that. The precise reflection behavior does not matter.Solution
#[derive(Reflect)], ignore fields whose types aren't reflectable.App::register_asset_reflectin theMeshPlugin.Changelog
Meshnow implementsReflect.