Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: Remove unused doc comments. #9795

Merged
merged 1 commit into from
Sep 13, 2023
Merged

examples: Remove unused doc comments. #9795

merged 1 commit into from
Sep 13, 2023

Conversation

waywardmonkeys
Copy link
Contributor

Objective

  • Compile all targets without warnings about unused doc comments.

Solution

  • Turn unused doc comments into regular comments. Doc comments aren't supported on expressions, so they can just be regular comments.

@nicopap nicopap added C-Examples An addition or correction to our examples A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Sep 13, 2023
@james7132 james7132 added this pull request to the merge queue Sep 13, 2023
Merged via the queue into bevyengine:main with commit 5eb6889 Sep 13, 2023
26 checks passed
@waywardmonkeys waywardmonkeys deleted the remove-unused-doc-comments branch September 14, 2023 03:13
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@waywardmonkeys
examples: Remove unused doc comments. (bevyengine#9795)
d626161 
# Objective

- Compile all targets without warnings about unused doc comments.

## Solution

- Turn unused doc comments into regular comments. Doc comments aren't
supported on expressions, so they can just be regular comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@nicopap nicopap nicopap approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waywardmonkeys @james7132 @nicopap