-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish documenting bevy_scene
#9949
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicopap
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! I really like it. I added a couple suggestions, but as-is, it's already good to go for me!
nicopap
added
C-Docs
An addition or correction to our documentation
A-Scenes
Serialized ECS data stored on the disk
labels
Sep 28, 2023
Kanabenki
force-pushed
the
bevy_scene-doc
branch
2 times, most recently
from
September 28, 2023 13:05
eee4f04
to
4cd1c5b
Compare
rparrett
reviewed
Sep 28, 2023
Kanabenki
force-pushed
the
bevy_scene-doc
branch
from
September 28, 2023 15:59
4cd1c5b
to
dcfbe9d
Compare
alice-i-cecile
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice stuff, thanks!
alice-i-cecile
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Sep 28, 2023
mockersf
reviewed
Sep 28, 2023
Document the remaining items and add a `warn(missing_doc)` crate attribute.
Kanabenki
force-pushed
the
bevy_scene-doc
branch
from
September 29, 2023 06:53
dcfbe9d
to
07e3ca0
Compare
nicopap
approved these changes
Oct 1, 2023
45 tasks
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Oct 3, 2023
# Objective Finish documenting `bevy_scene`. ## Solution Document the remaining items and add a crate-level `warn(missing_doc)` attribute as for the other crates with completed documentation.
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Oct 3, 2023
# Objective Finish documenting `bevy_scene`. ## Solution Document the remaining items and add a crate-level `warn(missing_doc)` attribute as for the other crates with completed documentation.
regnarock
pushed a commit
to regnarock/bevy
that referenced
this pull request
Oct 13, 2023
# Objective Finish documenting `bevy_scene`. ## Solution Document the remaining items and add a crate-level `warn(missing_doc)` attribute as for the other crates with completed documentation.
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective Finish documenting `bevy_scene`. ## Solution Document the remaining items and add a crate-level `warn(missing_doc)` attribute as for the other crates with completed documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Scenes
Serialized ECS data stored on the disk
C-Docs
An addition or correction to our documentation
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Finish documenting
bevy_scene
.Solution
Document the remaining items and add a crate-level
warn(missing_doc)
attribute as for the other crates with completed documentation.