Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Change Option<With<T>> query params to Has<T> #9959

Merged
merged 3 commits into from
Oct 2, 2023
Merged

refactor: Change Option<With<T>> query params to Has<T> #9959

merged 3 commits into from
Oct 2, 2023

Conversation

james7132
Copy link
Member

Objective

Has<T> was added to bevy_ecs, but we're still using the Option<With<T>> pattern in multiple locations.

Solution

Replace them with Has<T>.

@james7132 james7132 added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Sep 29, 2023
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 29, 2023
TimJentzsch
TimJentzsch approved these changes Sep 30, 2023
View reviewed changes
crates/bevy_animation/src/lib.rs Outdated Show resolved Hide resolved
@james7132 james7132 added this pull request to the merge queue Oct 2, 2023
Merged via the queue into bevyengine:main with commit 21518de Oct 2, 2023
21 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Oct 3, 2023
@james7132 @ameknite
refactor: Change Option<With<T>> query params to Has<T> (bevyengine#9959
f1493ca 
)

# Objective
`Has<T>` was added to bevy_ecs, but we're still using the
`Option<With<T>>` pattern in multiple locations.

## Solution
Replace them with `Has<T>`.
ameknite pushed a commit to ameknite/bevy that referenced this pull request Oct 3, 2023
@james7132 @ameknite
refactor: Change Option<With<T>> query params to Has<T> (bevyengine#9959
28afa2d 
)

# Objective
`Has<T>` was added to bevy_ecs, but we're still using the
`Option<With<T>>` pattern in multiple locations.

## Solution
Replace them with `Has<T>`.
regnarock pushed a commit to regnarock/bevy that referenced this pull request Oct 13, 2023
@james7132
refactor: Change Option<With<T>> query params to Has<T> (bevyengine#9959
41b9fdc 
)

# Objective
`Has<T>` was added to bevy_ecs, but we're still using the
`Option<With<T>>` pattern in multiple locations.

## Solution
Replace them with `Has<T>`.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@james7132
refactor: Change Option<With<T>> query params to Has<T> (bevyengine#9959
baa2e59 
)

# Objective
`Has<T>` was added to bevy_ecs, but we're still using the
`Option<With<T>>` pattern in multiple locations.

## Solution
Replace them with `Has<T>`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@mockersf mockersf mockersf approved these changes

@TimJentzsch TimJentzsch TimJentzsch approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@james7132 @superdump @mockersf @TimJentzsch