Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish documenting bevy_gltf #9998

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Finish documenting bevy_gltf #9998

merged 1 commit into from
Oct 3, 2023

Conversation

Kanabenki
Copy link
Contributor

Objective

  • Finish documenting bevy_gltf.

Solution

  • Document the remaining items, add links to the glTF spec where relevant. Add the warn(missing_doc) attribute.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Assets Load files from disk to use for things like images, models, and sounds A-Animation Make things move and change over time labels Oct 2, 2023
alice-i-cecile
alice-i-cecile approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 3, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 3, 2023
Merged via the queue into bevyengine:main with commit 375af64 Oct 3, 2023
22 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Oct 3, 2023
@Kanabenki @ameknite
Finish documenting bevy_gltf (bevyengine#9998)
46dce84 
# Objective

- Finish documenting `bevy_gltf`.

## Solution

- Document the remaining items, add links to the glTF spec where
relevant. Add the `warn(missing_doc)` attribute.
@Kanabenki Kanabenki mentioned this pull request Oct 3, 2023
Open
45 tasks
regnarock pushed a commit to regnarock/bevy that referenced this pull request Oct 13, 2023
@Kanabenki
Finish documenting bevy_gltf (bevyengine#9998)
e3c39e8 
# Objective

- Finish documenting `bevy_gltf`.

## Solution

- Document the remaining items, add links to the glTF spec where
relevant. Add the `warn(missing_doc)` attribute.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@Kanabenki
Finish documenting bevy_gltf (bevyengine#9998)
4ae63d4 
# Objective

- Finish documenting `bevy_gltf`.

## Solution

- Document the remaining items, add links to the glTF spec where
relevant. Add the `warn(missing_doc)` attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@A-Walrus A-Walrus A-Walrus approved these changes

@mockersf mockersf Awaiting requested review from mockersf

Assignees
No one assigned
Labels
A-Animation Make things move and change over time A-Assets Load files from disk to use for things like images, models, and sounds C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kanabenki @alice-i-cecile @mockersf @A-Walrus