Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to plot throughput on summary page. #646

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

h33p
Copy link

@h33p h33p commented Jan 30, 2023

Fixes bheisler/cargo-criterion#9.

This was originally based on #315. I ported it to latest version, including support for the plotters backend. Both time and throughput charts are very similar, thus I decided to go additional arguments to Plotter::line_comparison function rather than a separate one.

Most notably, added LinePlotConfig type which configures whether line_comparison plots time or throughput. I had to employ a slightly dirty hack in throughput's LinePlotConfig scaling function, to make throughput scale consistent across the plot. It could have been possible to make it cleaner with modifications to ValueFormatter, but I decided against breaking public API.

@h33p
Copy link
Author

h33p commented Apr 2, 2023

Rebased to latest master

@qsantos
Copy link

qsantos commented Nov 16, 2023

@lemmih I have tested this PR, and it solves exactly a limitation I have encountered with Criterion. I am not familiar with Criterion's code base, but the changes look reasonable to me from a quick look. Is there anything in particular blocking this PR? Can @h33p or I do something to get it merged? Of course, I understand if you do not have the time to answer this.

@waywardmonkeys waywardmonkeys mentioned this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart throughput on parameterized benchmark page by default?
2 participants