Followed up with more fixes, after testing. #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test things better next time please. |
|
Hey. Thanks for the feedback. The issue is that I'd only heard about Tubeup a few days ago. Seeing that the entire program took up 3 scripts and a few hundres lines of code, I falsely assumed that my testing was adequate. In the future, I'll make sure to wait at least 23 hours before I fully commit to making a pull request like that. |
|
@Windows81 The contributions are always welcome, we can use all the help we can get. Feel free to keep a pr in draft mode if you want to ask for a code review. I'm also happy to write tests for code other people write, as it's not the most fun part 😆 Thank you again 🙇♂️ |
|
thank you for the bugfix @Windows81 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.