Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idempotent runs by locally tracking successful uploads (😘) #311

Closed
wants to merge 1 commit into from

Conversation

drzraf
Copy link
Contributor

@drzraf drzraf commented Sep 17, 2023

... the same way yt-dlp keep track of downloaded items.

…oaded the way

  yt-dlp keep track of downloaded items.

- Amend bibanon#19 by adding optional idempotency between runs:
  While concurrent-instances can still rely on a "clean" download directory (bibanon#19)
  a single upload node can use --use-upload-archive can avoid source files removal.
  Subsequent runs of `tubeup` will omit files already uploaded.

- Fixes bibanon#23 (and part of bibanon#233)
- NB: Ability for upload_ia() to return None, paves the way to fix bibanon#36 or bibanon#109
@vxbinaca
Copy link
Collaborator

#233 isn't a bug it's his inability to symlink. No. Also he needs to learn to use yt-dlp.

No local saving capability. I'll tease out the command and put it in README.md so all of Jasons little minions need to save the the videos locally. But no we're not doing local saving. Ever.

Do all of these needs to be in the same PR?

@vxbinaca
Copy link
Collaborator

vxbinaca commented Sep 18, 2023

Break the bug fixes out - and local no downloads aren't a bug, use yt-dlp - and I'll merge bug fixes.

@vxbinaca vxbinaca closed this Sep 18, 2023
@vxbinaca vxbinaca reopened this Sep 18, 2023
@vxbinaca
Copy link
Collaborator

oh wait this is all one PR. Split and I'll merge piecemeal

@vxbinaca vxbinaca closed this Sep 18, 2023
@drzraf
Copy link
Contributor Author

drzraf commented Sep 18, 2023

No local saving capability.

Do you mean, the tool must keep trying to bypass user control by forbidding any caching behavior or intelligent idempotency?

Regarding split, it's not clear which parts you want in or out. Do you mind providing more details about:

  • Why a resuming/caching queue is desirable for download (to spare resources), but wouldn't for upload (to spare resources)?
  • What would you expect from a split PR?
  • If this discussion slided away from technical details to more theoretical or ideological aspects, is there any modalities you suggest to get i discussed on sane, peaceful and rational grounds anyway (Github PR or Github discussion) and/or anyone you would want bring into such discussions?

Thank you!

@vxbinaca
Copy link
Collaborator

Why a resuming/caching queue is desirable for download (to spare resources), but wouldn't for upload (to spare resources)?

No. Learn to use yt-dlp. One can learn to use yt-dlps flags to download videos and metadata. I've offered to put a example command on the front page. No one wants to take the offer they want Tubeup to change.

Alternatively use Tubearchivist. Of course the best is to just learn yt-dlps flags.

We are not here to prevent or especially enable abuse of archive.org resources. Period. I do not on a personal level like seeing Archive.orgs servers filled with for example, Logan Paul or Linus Tech Tips videos. They can ban abusive people. And I'nm going to tip my hand here a bit and say I think I know where the desire for local saving comes from. We're not Archive Team.

Learn to use yt-dlp.

#19 - Fixed when the flag for delete on successful uploading was implemented YEARS ago - old and dead not changing.

Subsequent runs of tubeup will politely omit files already uploaded.

This feature already exists and is on by default. VideoID are one by one searched for on Archive.org before rip, and anything existing is skipped.

Thank you for your time on this PR. It's features either exist or aren't desired. Stick around you're needed for other things. Thank you.

@vxbinaca
Copy link
Collaborator

8d78be0

@drzraf drzraf mentioned this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script fails an entire channel upload if one video has already been uploaded by someone else.
2 participants