Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yt-dlp flags spring cleaning #312

Closed
wants to merge 1 commit into from
Closed

Conversation

vxbinaca
Copy link
Collaborator

  • Annotations are dead and not used on Youtube, it's safe to remove this flag. No extractors use annotations.
  • Delete call-home functionality to annoy about downloader updates from Youtube-dl days. We don't use that downloader anymore and that functionality isn't ideal and wasn't a good idea for me to put in.
  • YT-DLP uses ffmpeg by default and avconv wasa dead project back in 2015

@vxbinaca vxbinaca changed the title Update TubeUp.py yt-dlp flags spring cleaning Sep 18, 2023
@vxbinaca vxbinaca closed this Sep 18, 2023
@brandongalbraith
Copy link
Collaborator

Hey @vxbinaca! Do you recall why you decided not to ship these changes? Asking only out of curiosity!

@vxbinaca
Copy link
Collaborator Author

Hey @vxbinaca! Do you recall why you decided not to ship these changes? Asking only out of curiosity!

I think it didn't work re: unit tests I don't even remember doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants