-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(functional): Move functional tests to apps/core #816
Conversation
🦋 Changeset detectedLatest commit: 99f2902 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
032629a
to
ef5d7be
Compare
Successful test runs on CI: |
ef5d7be
to
5d1e48e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, otherwise looks good. I'll pull this down later to test with the CLI before I give a ✅
apps/core/tests/.env.example
Outdated
@@ -0,0 +1,2 @@ | |||
# Environment variables for tests | |||
PLAYWRIGHT_TEST_BASE_URL='https://catalyst-demo.site' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I think about it, let's add remove this for now as we probably need to add some documentation around it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I have it documented in docs/monorepo.md
but this might also be another placeholder to add it as it's an environment variable.
51fc5b1
to
99f2902
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-7pk50j0py-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
What/Why?
As part of making functional tests optionally available to our users, we are moving our tests to
apps/core
so that they are now available through CLI setup.Testing
Tests should run as part of this PR. Verified it all locally.