Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: standardize actions #831

Merged
merged 1 commit into from
Apr 30, 2024
Merged

chore: standardize actions #831

merged 1 commit into from
Apr 30, 2024

Conversation

jorgemoya
Copy link
Contributor

What/Why?

Standardize actions by making sure actions have the same elementsd.

Testing

Locally.

@jorgemoya jorgemoya requested a review from a team as a code owner April 29, 2024 21:21
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 03e1e99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview Apr 30, 2024 4:46pm
catalyst-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 4:46pm
catalyst-test-store ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 4:46pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 4:46pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 4:46pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 4:46pm

jorgemoya
jorgemoya commented Apr 29, 2024
View reviewed changes
apps/core/app/[locale]/(default)/cart/_queries/get-shipping-countries.ts Outdated
@@ -3,6 +3,7 @@ import { getShippingZones } from '~/client/management/get-shipping-zones';

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved these files because they are not really actions, but mostly functions that call queries, not sure if this is the best approach.

@jorgemoya jorgemoya force-pushed the standarize-actions branch 2 times, most recently from dccef63 to e25bcc3 Compare April 30, 2024 16:32
@github-actions GitHub Actions
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-kxenkcejc-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@jorgemoya jorgemoya added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit 8349bbf Apr 30, 2024
18 checks passed
@jorgemoya jorgemoya deleted the standarize-actions branch April 30, 2024 17:29
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanceaclark chanceaclark chanceaclark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgemoya @chanceaclark