Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): accommodate recent category changes #889

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

deini
Copy link
Member

@deini deini commented May 8, 2024

What/Why?

A few tests broke after #880

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 7:48pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 7:48pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 7:48pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 7:48pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 7:48pm

Copy link

changeset-bot bot commented May 8, 2024

⚠️ No Changeset found

Latest commit: e339ec5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 8, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-ho0wrmga0-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 90

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 98
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92

@deini deini marked this pull request as ready for review May 8, 2024 19:53
@deini deini requested a review from a team as a code owner May 8, 2024 19:53
@deini deini added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit 665b166 May 8, 2024
11 checks passed
@deini deini deleted the deini/fix-tests branch May 8, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants